Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove duplicate instruction in ReadMe #3031

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

TangentFoxy
Copy link
Contributor

The docker-compose rebuilds the image, so it's a waste of time to build it first.

The docker-compose rebuilds the image, so it's a waste of time to build it first.
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 63b8163
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/6768130a9a68dd000897cac4

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 63b8163
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/6768130aad51c100086b810a
😎 Deploy Preview https://deploy-preview-3031--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TangentFoxy TangentFoxy changed the title Remove duplicate instruction in ReadMe docs: Remove duplicate instruction in ReadMe Oct 31, 2024
Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report. That's correct. docker-compose up should build the container so no need to build before that step. I adjusted the last step to include --build flag so that it can ensure a clean build.

@shuuji3 shuuji3 added this pull request to the merge queue Dec 22, 2024
Merged via the queue into elk-zone:main with commit 5e2df38 Dec 22, 2024
13 checks passed
ayoayco pushed a commit that referenced this pull request Feb 6, 2025
ayoayco pushed a commit that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants